Make .val(undefined) == .val("") and chainable; fixes #4130.

[jquery.git] / src / attributes.js

diff --git a/src/attributes.js b/src/attributes.js
index b0a0e91..fd3e38a 100644 (file)
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -1,7 +1,7 @@
 (function( jQuery ) {
 
 var rclass = /[\n\t]/g,
-       rspace = /\s+/,
+       rspaces = /\s+/,
        rreturn = /\r/g,
        rspecialurl = /^(?:href|src|style)$/,
        rtype = /^(?:button|input)$/i,
@@ -32,7 +32,7 @@ jQuery.fn.extend({
                }
 
                if ( value && typeof value === "string" ) {
-                       var classNames = (value || "").split( rspace );
+                       var classNames = (value || "").split( rspaces );
 
                        for ( var i = 0, l = this.length; i < l; i++ ) {
                                var elem = this[i];
@@ -66,7 +66,7 @@ jQuery.fn.extend({
                }
 
                if ( (value && typeof value === "string") || value === undefined ) {
-                       var classNames = (value || "").split(rspace);
+                       var classNames = (value || "").split( rspaces );
 
                        for ( var i = 0, l = this.length; i < l; i++ ) {
                                var elem = this[i];
@@ -104,7 +104,7 @@ jQuery.fn.extend({
                                // toggle individual class names
                                var className, i = 0, self = jQuery(this),
                                        state = stateVal,
-                                       classNames = value.split( rspace );
+                                       classNames = value.split( rspaces );
 
                                while ( (className = classNames[ i++ ]) ) {
                                        // check each className given, space seperated list
@@ -136,7 +136,7 @@ jQuery.fn.extend({
        },
 
        val: function( value ) {
-               if ( value === undefined ) {
+               if ( !arguments.length ) {
                        var elem = this[0];
 
                        if ( elem ) {
@@ -163,8 +163,10 @@ jQuery.fn.extend({
                                        for ( var i = one ? index : 0, max = one ? index + 1 : options.length; i < max; i++ ) {
                                                var option = options[ i ];
 
-                                               if ( option.selected ) {
-                                                       // Get the specifc value for the option
+                                               // Don't return options that are disabled or in a disabled optgroup
+                                               if ( option.selected && !option.disabled && 
+                                                               (!option.parentNode.disabled || !jQuery.nodeName( option.parentNode, "optgroup" )) ) {
+                                                       // Get the specific value for the option
                                                        value = jQuery(option).val();
 
                                                        // We don't need an array for one selects
@@ -207,9 +209,10 @@ jQuery.fn.extend({
                                val = value.call(this, i, self.val());
                        }
 
-                       // Typecast each time if the value is a Function and the appended
-                       // value is therefore different each time.
-                       if ( typeof val === "number" ) {
+                       // Treat null/undefined as ""; convert numbers to string
+                       if ( val == null ) {
+                               val = "";
+                       } else if ( typeof val === "number" ) {
                                val += "";
                        }