Add .width() and .height() unit test for empty sets. Fix .height() test that was...

[jquery.git] / src / data.js

diff --git a/src/data.js b/src/data.js
index c524a45..d38d47d 100644 (file)
--- a/src/data.js
+++ b/src/data.js
@@ -27,7 +27,8 @@ jQuery.extend({
                        elem;
 
                var id = elem[ jQuery.expando ], cache = jQuery.cache, thisCache,
-                       isNode = elem.nodeType;
+                       isNode = elem.nodeType,
+                       store;
 
                if ( !id && typeof name === "string" && data === undefined ) {
                        return;
@@ -49,8 +50,9 @@ jQuery.extend({
                        if ( isNode ) {
                                cache[ id ] = jQuery.extend(true, {}, name);
                        } else {
+                               store = jQuery.extend(true, {}, name);
                                cache[ id ] = function() {
-                                       return jQuery.extend(true, {}, name);
+                                       return store;
                                };
                        }
 
@@ -58,7 +60,7 @@ jQuery.extend({
                        if ( isNode ) {
                                cache[ id ] = {};
                        } else {
-                               var store = {};
+                               store = {};
                                cache[ id ] = function() {
                                        return store;
                                };
@@ -66,7 +68,7 @@ jQuery.extend({
                        
                }
 
-               thisCache = isNode? cache[ id ] : cache[ id ]();
+               thisCache = isNode ? cache[ id ] : cache[ id ]();
 
                // Prevent overriding the named cache with undefined values
                if ( data !== undefined ) {
@@ -141,13 +143,18 @@ jQuery.fn.extend({
                        if ( data === undefined && this.length ) {
                                data = jQuery.data( this[0], key );
                        }
+
                        return data === undefined && parts[1] ?
                                this.data( parts[0] ) :
                                data;
+
                } else {
-                       return this.trigger("setData" + parts[1] + "!", [parts[0], value]).each(function() {
+                       return this.each(function() {
+                               var $this = jQuery( this ), args = [ parts[0], value ];
+
+                               $this.triggerHandler( "setData" + parts[1] + "!", args );
                                jQuery.data( this, key, value );
-                               jQuery.event.trigger( "changeData" + parts[1] + "!", [parts[0], value], this );
+                               $this.triggerHandler( "changeData" + parts[1] + "!", args );
                        });
                }
        },