X-Git-Url: http://git.asbjorn.it/?a=blobdiff_plain;f=src%2Ffx%2Ffx.js;h=075d1abb49280225caf6345d8316ca9d003f9d2d;hb=97f2032e13b85db72910e9cc1e75f2eb75e43dc4;hp=f53b2b29e5ed243c53f64af41c8b5e97c419316c;hpb=8b683b891f2cfd299c1d0708bb41ea26393ea417;p=jquery.git diff --git a/src/fx/fx.js b/src/fx/fx.js index f53b2b2..075d1ab 100644 --- a/src/fx/fx.js +++ b/src/fx/fx.js @@ -315,19 +315,34 @@ jQuery.fn.extend({ opt = jQuery.speed(speed, easing, callback), self = this; - for ( var p in prop ) + for ( var p in prop ) { if ( prop[p] == "hide" && hidden || prop[p] == "show" && !hidden ) return jQuery.isFunction(opt.complete) && opt.complete.apply(this); - + + if ( p == "height" || p == "width" ) { + // Store display property + opt.display = jQuery.css(this, "display"); + + // Make sure that nothing sneaks out + opt.overflow = this.style.overflow; + } + } + + if ( opt.overflow != null ) + this.style.overflow = "hidden"; + this.curAnim = jQuery.extend({}, prop); jQuery.each( prop, function(name, val){ var e = new jQuery.fx( self, opt, name ); if ( val.constructor == Number ) - e.custom( e.cur(), val ); + e.custom( e.cur() || 0, val ); else e[ val == "toggle" ? hidden ? "show" : "hide" : val ]( prop ); }); + + // For JS strict compliance + return true; }); }, @@ -364,7 +379,7 @@ jQuery.extend({ complete: fn || !fn && easing || jQuery.isFunction( speed ) && speed, duration: speed, - easing: fn && easing || easing && easing.constructor != Function && easing || "swing" + easing: fn && easing || easing && easing.constructor != Function && easing }; opt.duration = (opt.duration && opt.duration.constructor == Number ? @@ -409,28 +424,11 @@ jQuery.extend({ timers: [], - /* - * I originally wrote fx() as a clone of moo.fx and in the process - * of making it small in size the code became illegible to sane - * people. You've been warned. - */ - fx: function( elem, options, prop ){ - var z = this; - - // The styles - var y = elem.style; + var z = this, y = elem.style, + isprop = elem[prop] != null && y[prop] == null; - if ( prop == "height" || prop == "width" ) { - // Store display property - var oldDisplay = jQuery.css(elem, "display"); - - // Make sure that nothing sneaks out - var oldOverflow = y.overflow; - y.overflow = "hidden"; - } - // Simple function for setting a style value z.a = function(){ if ( options.step ) @@ -439,8 +437,14 @@ jQuery.extend({ if ( prop == "opacity" ) jQuery.attr(y, "opacity", z.now); // Let attr handle opacity else { - y[prop] = parseInt(z.now) + "px"; - y.display = "block"; // Set display property to block for animation + if ( isprop ) + elem[prop] = parseInt(z.now); + else + y[prop] = parseInt(z.now) + "px"; + + // Set display property to block for height/width animations + if ( prop == "height" || prop == "width" ) + y.display = "block"; } }; @@ -451,6 +455,7 @@ jQuery.extend({ // Get the current size z.cur = function(){ + if ( isprop ) return elem[prop]; var r = parseFloat( jQuery.curCSS(elem, prop) ); return r && r > -10000 ? r : z.max(); }; @@ -529,12 +534,12 @@ jQuery.extend({ done = false; if ( done ) { - if ( oldDisplay != null ) { + if ( options.display != null ) { // Reset the overflow - y.overflow = oldOverflow; + y.overflow = options.overflow; // Reset the display - y.display = oldDisplay; + y.display = options.display; if ( jQuery.css(elem, "display") == "none" ) y.display = "block"; } @@ -561,7 +566,7 @@ jQuery.extend({ var p = n / options.duration; // Perform the easing function, defaults to swing - z.now = jQuery.easing[options.easing](p, n, firstNum, (lastNum-firstNum), options.duration); + z.now = jQuery.easing[options.easing || (jQuery.easing.swing ? "swing" : "linear")](p, n, firstNum, (lastNum-firstNum), options.duration); // Perform the next step of the animation z.a();