X-Git-Url: http://git.asbjorn.it/?a=blobdiff_plain;f=src%2Foffset.js;h=a35fed5613e6c723a01be4231f47d416b3d0be33;hb=9a7652260b7addcf8874bd46926ff92182b500ea;hp=4de37a0ba3de65d264eef38403d8ffaffb280f60;hpb=3f5ff3097c315456fe92c9b1e4578590e1eb8648;p=jquery.git diff --git a/src/offset.js b/src/offset.js index 4de37a0..a35fed5 100644 --- a/src/offset.js +++ b/src/offset.js @@ -101,23 +101,23 @@ jQuery.fn.offset = function() { jQuery.fn.extend({ position: function() { - var left = 0, top = 0, elem = this[0], offset, parentOffset, offsetParent, results; + var left = 0, top = 0, results; - if (elem) { + if ( this[0] ) { // Get *real* offsetParent - offsetParent = this.offsetParent(); + var offsetParent = this.offsetParent(), - // Get correct offsets - offset = this.offset(); - parentOffset = offsetParent.offset(); + // Get correct offsets + offset = this.offset(), + parentOffset = offsetParent.offset(); // Subtract element margins - offset.top -= parseInt( jQuery.curCSS(elem, 'marginTop', true) ) || 0; - offset.left -= parseInt( jQuery.curCSS(elem, 'marginLeft', true) ) || 0; + offset.top -= num( this, 'marginTop' ); + offset.left -= num( this, 'marginLeft' ); // Add offsetParent borders - parentOffset.top += parseInt( jQuery.curCSS(offsetParent[0], 'borderTopWidth', true) ) || 0; - parentOffset.left += parseInt( jQuery.curCSS(offsetParent[0], 'borderLeftWidth', true) ) || 0; + parentOffset.top += num( offsetParent, 'borderTopWidth' ); + parentOffset.left += num( offsetParent, 'borderLeftWidth' ); // Subtract the two offsets results = { @@ -140,7 +140,9 @@ jQuery.fn.extend({ // Create scrollLeft and scrollTop methods jQuery.each( ['Left', 'Top'], function(i, name) { - jQuery.fn[ 'scroll' + name ] = function(val) { + var method = 'scroll' + name; + + jQuery.fn[ method ] = function(val) { if (!this[0]) return; return val != undefined ? @@ -149,17 +151,17 @@ jQuery.each( ['Left', 'Top'], function(i, name) { this.each(function() { this == window || this == document ? window.scrollTo( - name == 'Left' ? val : jQuery(window)[ 'scrollLeft' ](), - name == 'Top' ? val : jQuery(window)[ 'scrollTop' ]() + !i ? val : jQuery(window).scrollLeft(), + i ? val : jQuery(window).scrollTop() ) : - this[ 'scroll' + name ] = val; + this[ method ] = val; }) : // Return the scroll offset this[0] == window || this[0] == document ? - self[ (name == 'Left' ? 'pageXOffset' : 'pageYOffset') ] || - jQuery.boxModel && document.documentElement[ 'scroll' + name ] || - document.body[ 'scroll' + name ] : - this[0][ 'scroll' + name ]; + self[ i ? 'pageYOffset' : 'pageXOffset' ] || + jQuery.boxModel && document.documentElement[ method ] || + document.body[ method ] : + this[0][ method ]; }; });