Make sure that .offset() doesn't fail against disconnected DOM nodes. Fixes #4996.

diff --git a/src/offset.js b/src/offset.js
index 650cc08..39763ee 100644 (file)
--- a/src/offset.js
+++ b/src/offset.js
@@ -5,7 +5,7 @@ var rtable = /^t(?:able|d|h)$/i,
 
 if ( "getBoundingClientRect" in document.documentElement ) {
        jQuery.fn.offset = function( options ) {
-               var elem = this[0];
+               var elem = this[0], box;
 
                if ( options ) { 
                        return this.each(function( i ) {
@@ -21,8 +21,14 @@ if ( "getBoundingClientRect" in document.documentElement ) {
                        return jQuery.offset.bodyOffset( elem );
                }
 
-               var box = elem.getBoundingClientRect(),
-                       doc = elem.ownerDocument,
+               try {
+                       box = elem.getBoundingClientRect();
+
+               } catch(e) {
+                       box = { top: elem.offsetTop, left: elem.offsetLeft };
+               }
+
+               var doc = elem.ownerDocument,
                        body = doc.body,
                        docElem = doc.documentElement,
                        win = getWindow(doc),

diff --git a/test/unit/offset.js b/test/unit/offset.js
index ed3d962..8797531 100644 (file)
--- a/test/unit/offset.js
+++ b/test/unit/offset.js
@@ -1,5 +1,14 @@
 module("offset");
 
+test("disconnected node", function() {
+       expect(2);
+
+       var result = jQuery( document.createElement("div") ).offset();
+
+       equals( result.top, 0, "Check top" );
+       equals( result.left, 0, "Check left" );
+});
+
 var supportsScroll = false;
 
 testoffset("absolute"/* in iframe */, function($, iframe) {