From 971840f343dae04fdc6ff51ecb03ec8b3aaee067 Mon Sep 17 00:00:00 2001 From: Brandon Aaron Date: Fri, 12 Oct 2007 12:51:07 +0000 Subject: [PATCH] Fixed .val(String) for select elements (#1760) [Thanks Sam] --- src/core.js | 2 +- test/unit/core.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/core.js b/src/core.js index 9fd0168..b3b0a9d 100644 --- a/src/core.js +++ b/src/core.js @@ -407,7 +407,7 @@ jQuery.fn = jQuery.prototype = { jQuery.inArray( this.text, values ) >= 0); }); - if ( !tmp.length ) + if ( !values.length ) this.selectedIndex = -1; } else diff --git a/test/unit/core.js b/test/unit/core.js index 32ff83e..eee1740 100644 --- a/test/unit/core.js +++ b/test/unit/core.js @@ -824,11 +824,14 @@ test("val()", function() { }); test("val(String)", function() { - expect(2); + expect(3); document.getElementById('text1').value = "bla"; ok( $("#text1").val() == "bla", "Check for modified value of input element" ); $("#text1").val('test'); ok ( document.getElementById('text1').value == "test", "Check for modified (via val(String)) value of input element" ); + + $("#select1").val("3"); + ok( $("#select1").val() == "3", "Check for modified (via val(String)) value of select element" ); }); test("html(String)", function() { -- 1.7.10.4